bpo-31658: Make xml.sax.parse accepting Path objects by BoboTiG · Pull Request #8564 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.2k
Merged
scoder merged 6 commits intopython:masterfrom
Apr 14, 2019Merged
bpo-31658: Make xml.sax.parse accepting Path objects#8564
scoder merged 6 commits intopython:masterfrom
bpo-31658: Make xml.sax.parse accepting Path objects#8564
scoder merged 6 commits intopython:masterfrom
Conversation
Copy link
Contributor
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting review
label
BoboTiG
force-pushed
the
fix-issue-31658
branch
3 times, most recently
from
96f896f to
8dd5dbc
Compare
merwok reviewed Dec 20, 2018
Lib/xml/sax/saxutils.py
Outdated
Show resolved
Hide resolved
Lib/xml/sax/saxutils.py Outdated Show resolved Hide resolved
BoboTiG
force-pushed
the
fix-issue-31658
branch
from
8dd5dbc to
04498f8
Compare
merwok reviewed Jan 2, 2019
Doc/library/xml.sax.reader.rst
Outdated
Show resolved
Hide resolved
Doc/library/xml.sax.reader.rst Outdated Show resolved Hide resolved
BoboTiG and others added 3 commits
January 2, 2019 18:07Copy link
Contributor Author
BoboTiG
commented
Jan 7, 2019
BoboTiG commented
Jan 7, 2019@merwok do you think we can move on?
Lib/test/test_sax.py
Outdated
Show resolved
Hide resolved
Lib/test/test_sax.py Outdated Show resolved Hide resolved
tirkarthi reviewed Jan 8, 2019
Misc/NEWS.d/next/Library/2018-07-30-12-00-15.bpo-31658._bx7a_.rst
Outdated
Show resolved
Hide resolved
Misc/NEWS.d/next/Library/2018-07-30-12-00-15.bpo-31658._bx7a_.rst Outdated Show resolved Hide resolved
Copy link
Contributor Author
BoboTiG
commented
Feb 21, 2019
BoboTiG commented
Feb 21, 2019What is the status? Do you think it needs more work?
Copy link
Member
Code looks good to me, but I’m a little too busy to merge PRs, watch buildbots, etc.
scoder
merged commit
929b704
into
python:master
bedevere-bot
removed
the
awaiting review
label
BoboTiG
deleted the
fix-issue-31658
branch
Copy link
Member
merwok
commented
Apr 15, 2019
merwok commented
Apr 15, 2019Thanks again for the patch and thanks @scoder for merging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment