bpo-34120: fix text viewer to call grab_release() only when needed by taleinat · Pull Request #8616 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@taleinat

Copy link Copy Markdown

Contributor

@taleinat taleinat commented

Aug 2, 2018

edited by bedevere-bot

Loading

Fixing a bug in my recent fix for this issue.

https://bugs.python.org/issue34120

@taleinat taleinat requested a review from terryjreedy as a code owner

August 2, 2018 07:14

@taleinat taleinat added type-bug

An unexpected behavior, bug, or error

needs backport to 3.6 skip news labels

Aug 2, 2018

@taleinat taleinat merged commit dd74369 into python:master

Aug 2, 2018

@miss-islington

Copy link Copy Markdown

Contributor

Thanks @taleinat for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot

Copy link Copy Markdown

GH-8617 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Aug 2, 2018
…ythonGH-8616)

(cherry picked from commit dd74369)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>

@bedevere-bot

Copy link Copy Markdown

GH-8618 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Aug 2, 2018
…ythonGH-8616)

(cherry picked from commit dd74369)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>

@taleinat taleinat deleted the bpo-34120/textview_grab_release_fix branch

August 2, 2018 07:33

miss-islington added a commit that referenced this pull request

Aug 2, 2018
…H-8616)

(cherry picked from commit dd74369)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>

miss-islington added a commit that referenced this pull request

Aug 2, 2018
…H-8616)

(cherry picked from commit dd74369)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Assignees

No one assigned

Labels

skip news type-bug

An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@taleinat @miss-islington @bedevere-bot @the-knights-who-say-ni