[3.7] bpo-32933: Implement __iter__ method on mock_open() (GH-5974) by miss-islington · Pull Request #9311 · python/cpython
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34.4k
Merged
berkerpeksag merged 2 commits intopython:3.7from
Sep 14, 2018Merged
[3.7] bpo-32933: Implement __iter__ method on mock_open() (GH-5974)#9311
berkerpeksag merged 2 commits intopython:3.7from
[3.7] bpo-32933: Implement __iter__ method on mock_open() (GH-5974)#9311
berkerpeksag merged 2 commits intopython:3.7from
Conversation
Copy link Copy Markdown
Contributor
(cherry picked from commit 2087023)
Co-authored-by: Tony Flury anthony.flury@btinternet.com
(cherry picked from commit 2087023) Co-authored-by: Tony Flury <anthony.flury@btinternet.com>
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
mentioned this pull request
bedevere-bot
added
the
awaiting review
label
Doc/library/unittest.mock.rst Outdated
| .. versionchanged:: 3.5 | ||
| *read_data* is now reset on each call to the *mock*. | ||
|
|
||
| .. versionchanged:: 3.8 |
Copy link Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ned-deily should I change 3.8 to 3.7.1 or remove the versionchanged directive? (I will submit a separate PR for master if we decide to remove it.)
Copy link Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should change it to 3.7.1 for the 3.7 branch. Thanks!
Copy link Copy Markdown
Contributor Author
miss-islington
commented
Sep 14, 2018
miss-islington commented
Sep 14, 2018@TonyFlury and @berkerpeksag: Status check is done, and it's a success ✅ .
berkerpeksag
merged commit
c83c375
into
python:3.7
bedevere-bot
removed
the
awaiting review
label
miss-islington
deleted the
backport-2087023-3.7
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants