Home Original page

Fix crash on unimported Any in TypedDict by ilevkivskyi · Pull Request #16510 · python/mypy

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@ilevkivskyi

Copy link Copy Markdown

Member

Fixes #16498

Fix is trivial: no operations can be done with Required types before unwrapping (because they are not real types).

@github-actions

This comment has been minimized.

Copy link Copy Markdown

Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I figured this would probably be a simple fix

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

@github-actions

This comment has been minimized.

@github-actions

Copy link Copy Markdown

Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@ilevkivskyi ilevkivskyi merged commit 8c8aa10 into python:master

Nov 17, 2023

@ilevkivskyi ilevkivskyi deleted the fix-any-crash branch

November 17, 2023 00:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@JukkaL JukkaL Awaiting requested review from JukkaL

@hauntsaninja hauntsaninja Awaiting requested review from hauntsaninja

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mypy crashes when importing types_aiobotocore_s3

2 participants

@ilevkivskyi @JelleZijlstra