Micro-optimization: Avoid temporary set creation in is_proper_subtype by JukkaL · Pull Request #19463 · python/mypy

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@JukkaL

Copy link Copy Markdown

Collaborator

@JukkaL JukkaL commented

Jul 16, 2025

edited

Loading

This was suggested by @sterliakov in #19384 (comment)

This is a part of a set of micro-optimizations that improve self check performance by ~5.5%.

This is a part of a set of micro-optimizations that improve self check
performance by ~5.5%.

@JukkaL JukkaL changed the title Micro-optimization: Avoid temporary set creation is_proper_subtype Micro-optimization: Avoid temporary set creation in is_proper_subtype

Jul 16, 2025

@github-actions

Copy link Copy Markdown

Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@JukkaL JukkaL merged commit ca738e5 into master

Jul 16, 2025

20 checks passed

@JukkaL JukkaL deleted the opt-5 branch

July 16, 2025 17:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

1 more reviewer

@sterliakov sterliakov sterliakov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JukkaL @sterliakov