Make it so that error comments in tests are not ignored if they occur at the beginning of a line by wyattscarpenter · Pull Request #21172 · python/mypy

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@wyattscarpenter

Copy link Copy Markdown

Contributor

@wyattscarpenter wyattscarpenter commented

Apr 5, 2026

edited

Loading

Fixes #19547. Previously, error comments in a test were silently ignored if occurring on an empty line, but it is better that they should be honored, due to the principle of least surprise.

@wyattscarpenter wyattscarpenter marked this pull request as ready for review

April 5, 2026 13:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"# E:" lines (etc) in test files are ignored at the beginning of lines

1 participant

@wyattscarpenter