Add tomli_loads benchmark by kumaraditya303 · Pull Request #200 · python/pyperformance
Navigation Menu
{{ message }}
python / pyperformance Public
- Notifications You must be signed in to change notification settings
- Fork 201
Merged
kumaraditya303 merged 12 commits intopython:mainfrom
kumaraditya303:tomllib
kumaraditya303 merged 12 commits intopython:mainfrom
kumaraditya303:tomllib
Conversation
Copy link Copy Markdown
Contributor Author
kumaraditya303
commented
May 14, 2022
kumaraditya303 commented
May 14, 2022It seems like requires-python = ">=3.11" has no effect and seems broken.
kumaraditya303
marked this pull request as ready for review
kumaraditya303
requested a review
from ericsnowcurrently
kumaraditya303 added 5 commits
May 22, 2022 15:55ericsnowcurrently requested changes May 24, 2022
Copy link Copy Markdown
Member
ericsnowcurrently
left a comment
ericsnowcurrently
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! It mostly LGTM. There's only one thing I'd like added.
pyperformance/data-files/benchmarks/bm_tomllib_loads/run_benchmark.py
Outdated
Show resolved
Hide resolved
pyperformance/data-files/benchmarks/bm_tomllib_loads/run_benchmark.py Outdated Show resolved Hide resolved
kumaraditya303 added 2 commits
May 25, 2022 09:57
kumaraditya303
requested a review
from ericsnowcurrently
ericsnowcurrently approved these changes May 27, 2022
Copy link Copy Markdown
Member
ericsnowcurrently
left a comment
ericsnowcurrently
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for working on this.
pyperformance/data-files/benchmarks/bm_tomllib_loads/generate_data.py
Outdated
Show resolved
Hide resolved
pyperformance/data-files/benchmarks/bm_tomllib_loads/generate_data.py Outdated Show resolved Hide resolved
…data.py Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
ericsnowcurrently
removed their assignment
Copy link Copy Markdown
Member
ericsnowcurrently
commented
Jun 10, 2022
ericsnowcurrently commented
Jun 10, 2022We can merge this once the tests are passing. Do you know what the problem is?
Copy link Copy Markdown
Contributor Author
See #200 (comment)
The issue is that requires-python metadata has no effect.
Copy link Copy Markdown
Member
ericsnowcurrently
commented
Jun 10, 2022
ericsnowcurrently commented
Jun 10, 2022Ah, right. I'll take a look at that real quick and then merge it.
Copy link Copy Markdown
Contributor
mdboom
commented
Jun 17, 2022
mdboom commented
Jun 17, 2022Maybe we should have this install toml from PyPI instead of only using the stdlib one? That would give us more Python version coverage.
Copy link Copy Markdown
Contributor
hauntsaninja
commented
Jun 17, 2022
hauntsaninja commented
Jun 17, 2022(tomllib is based on pypi's tomli, not toml)
AlexWaygood
mentioned this pull request
kumaraditya303
changed the title
Add tomllib.loads benchmark
Add tomli_loads benchmark
kumaraditya303 added 2 commits
April 7, 2023 07:41
kumaraditya303
merged commit
9c58774
into
python:main
kumaraditya303
deleted the
tomllib
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants