Add benchmarks for the decimal module by mdboom · Pull Request #341 · python/pyperformance

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@mdboom

Copy link Copy Markdown

Contributor

@mdboom mdboom commented

Jun 14, 2024

These currently exist in the CPython source, but it would be good to have them here for continuous benchmarking.

These currently exist in the [CPython source](https://github.com/python/cpython/blob/main/Modules/_decimal/tests/bench.py),
but it would be good to have them here for continuous benchmarking.
Copy link Copy Markdown

Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Were you planning on adding the new benchmarks to the suite (i.e. pyperformance/data-files/benchmarks/MANIFEST)? At least you could add them there and leave them commented out. Is there any reason leave them out though?

@mdboom mdboom merged commit 9d19768 into python:main

Jun 18, 2024

skirpichev added a commit to skirpichev/pyperformance that referenced this pull request

Jan 19, 2026
They were not added here in python#341 for no reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdboom @ericsnowcurrently