Guard against empty pip install by emmatyping · Pull Request #41 · python/pyperformance

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Closed

emmatyping wants to merge 2 commits intopython:masterfrom

emmatyping:pep10fix

Closed

Guard against empty pip install#41

emmatyping wants to merge 2 commits intopython:masterfrom

emmatyping:pep10fix

Conversation

@emmatyping

Copy link Copy Markdown

Member

This avoids calling pip install without a distribution to install (which is an error in pip 10).
Fixes #40.

nooperpudd, jdemeyer, and sir-sigurd reacted with thumbs up emoji

@methane methane requested a review from vstinner

May 22, 2018 03:07

@methane

Copy link Copy Markdown

Member

methane commented

May 22, 2018

@vstinner Would you merge this and make a new release?

emmatyping and sir-sigurd reacted with thumbs up emoji

AnachronicNomad referenced this pull request

Aug 20, 2018
Indirect dependencies were used to install cffi, but Mercurial 4.0
doesn't depend on cffi anymore.

@vstinner

Copy link Copy Markdown

Member

Issue #40 has been fixed differently. This PR is no longer needed.

emmatyping reacted with thumbs up emoji

@vstinner vstinner closed this

Oct 16, 2018

@emmatyping emmatyping deleted the pep10fix branch

October 16, 2018 20:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emmatyping @methane @vstinner