Add tzdata as dev dependency and sync with tox.ini by wandrew004 · Pull Request #1159

Add tzdata as dev dependency and sync with tox.ini by wandrew004 · Pull Request #1159 · python-babel/babel

Summary

This resolves issues with missing dependencies when running tests on Windows

Related Issue

Closes #1150

Changes Made

Added tzdata to the dev dependencies in setup.py
Updated tox.ini to remove tzdata to make it consistent with setup.py

Testing Done

Recreated virtual environment and installed the dependencies using:

rm -rf venv
python -m venv venv
source venv/bin/activate
pip install -e .[dev]

Test output matches before and after changes

Tested on Windows OS

@tomasr8 Hi, do you need any additional tests or information before running the workflow tests?

Not in my power ;) @akx mind enabling the workflow?

akx requested changes Dec 9, 2024

akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond the inline note that the dependency should have the same platform marker it had in the tox.ini file (so as to avoid installing it on platforms where it's unnecessary), it would be better to do as I suggested in #1150 (comment), IOW get rid of the duplicated dependency lists altogether.

setup.py Outdated Show resolved Hide resolved

akx changed the title ~~Add tazdata as dev dependencies and sync with tox.ini~~ Add tzdata as dev dependency and sync with tox.ini

Dec 9, 2024

@akx Thanks for reviewing! I made changes per your feedback.

setup.py Outdated Show resolved Hide resolved

Co-authored-by: Tomas R. <tomas.roun8@gmail.com>

Can we run CI for these changes?

@akx Would you be able to take a look? Thanks!

akx approved these changes Jan 8, 2025

akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty of fixing the indentation failures, and reinstating BABEL_TOX_EXTRA_DEPS (which we need for GitHub Actions). LGTM, thanks, and sorry for the delays. Happy new year!