Implement zoneinfo support and make pytz optional by ds-cbo · Pull Request #940 · python-babel/babel
akx requested changes Jan 6, 2023
akx
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! ❤️
Some change requests, a big one being that pytz should IMO be supported alongside zoneinfo and preferred where available for backward compatibility reasons.
I'm all ears if there's something I'm missing and that'd be a terrible idea. :D
akx approved these changes Jan 11, 2023
akx
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you! 😄
akx
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters