Fix some CI errors by bnavigator · Pull Request #244 · python-control/Slycot
Navigation Menu
{{ message }}
python-control / Slycot Public
- Notifications You must be signed in to change notification settings
- Fork 45
Merged
murrayrm merged 5 commits intopython-control:masterfrom
Dec 23, 2024Merged
murrayrm merged 5 commits intopython-control:masterfrom
murrayrm merged 5 commits intopython-control:masterfrom
Conversation
Copy link Copy Markdown
Collaborator
Fixes:
- Ubuntu dropped the libopenblas-base "transition" package
- Mambaforge is deprecated
- Windows mamba commands silently fail
- macOS conda MKL error during pytest collection
bnavigator added 5 commits
December 23, 2024 11:56
bnavigator
mentioned this pull request
bnavigator
marked this pull request as ready for review
murrayrm
merged commit
a2ee35a
into
python-control:master
Copy link Copy Markdown
Member
slivingston
commented
Dec 24, 2024
slivingston commented
Dec 24, 2024Windows mamba commands silently fail
@bnavigator I looked in the recent CI logs, but I did not find evidence about the mamba command failing silently. Can you show me?
Also, I am motivated to ask because a mamba command is used similarly in python-control CI jobs: https://github.com/python-control/python-control/blob/a2c3b4c8db5558181357d2762e2285ae2ea01dc5/.github/workflows/os-blas-test-matrix.yml#L312
Copy link Copy Markdown
Collaborator
roryyorke
commented
Dec 24, 2024
roryyorke commented
Dec 24, 2024looks good, thanks @bnavigator .
Copy link Copy Markdown
Collaborator Author
Yes, I noticed that it works on the python-control jobs. But it failed here: https://github.com/python-control/Slycot/actions/runs/12467342357/job/34797033932#step:7:27 The commands just printed out the current windows version (!?)
Copy link Copy Markdown
Collaborator Author
bnavigator
commented
Dec 24, 2024
bnavigator commented
Dec 24, 2024Oh, it also does not work on the python-control jobs: https://github.com/python-control/python-control/actions/runs/12468173712/job/34799709028#step:7:27
The installs for slycot do not happen. Notice how the tests are automatically skipped by pytest: https://github.com/python-control/python-control/actions/runs/12468173712/job/34799709028#step:8:165
bnavigator
mentioned this pull request
roryyorke
mentioned this pull request
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment