Fix some CI errors by bnavigator · Pull Request #244 · python-control/Slycot

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@bnavigator

Copy link Copy Markdown

Collaborator

@bnavigator bnavigator commented

Dec 23, 2024

edited

Loading

Fixes:

  • Ubuntu dropped the libopenblas-base "transition" package
  • Mambaforge is deprecated
  • Windows mamba commands silently fail
  • macOS conda MKL error during pytest collection

@bnavigator bnavigator marked this pull request as ready for review

December 23, 2024 14:15

@murrayrm murrayrm merged commit a2ee35a into python-control:master

Dec 23, 2024

@slivingston

Copy link Copy Markdown

Member

Windows mamba commands silently fail

@bnavigator I looked in the recent CI logs, but I did not find evidence about the mamba command failing silently. Can you show me?

Also, I am motivated to ask because a mamba command is used similarly in python-control CI jobs: https://github.com/python-control/python-control/blob/a2c3b4c8db5558181357d2762e2285ae2ea01dc5/.github/workflows/os-blas-test-matrix.yml#L312

@roryyorke

Copy link Copy Markdown

Collaborator

looks good, thanks @bnavigator .

@bnavigator

Copy link Copy Markdown

Collaborator Author

bnavigator commented

Dec 24, 2024

edited

Loading

Yes, I noticed that it works on the python-control jobs. But it failed here: https://github.com/python-control/Slycot/actions/runs/12467342357/job/34797033932#step:7:27 The commands just printed out the current windows version (!?)

See conda-incubator/setup-miniconda#371

@bnavigator

Copy link Copy Markdown

Collaborator Author

Oh, it also does not work on the python-control jobs: https://github.com/python-control/python-control/actions/runs/12468173712/job/34799709028#step:7:27
The installs for slycot do not happen. Notice how the tests are automatically skipped by pytest: https://github.com/python-control/python-control/actions/runs/12468173712/job/34799709028#step:8:165

slivingston reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bnavigator @slivingston @roryyorke @murrayrm