Fix incorrect attribute name in `control.combine_time_responses` function by diemilio · Pull Request #1026 · python-control/python-control
Navigation Menu
{{ message }}
python-control / python-control Public
- Notifications You must be signed in to change notification settings
- Fork 453
Closed
Fix incorrect attribute name in control.combine_time_responses function#1026
diemilio wants to merge 0 commit intopython-control:mainfrom
Fix incorrect attribute name in control.combine_time_responses function#1026
diemilio wants to merge 0 commit intopython-control:mainfrom
Conversation
Copy link Copy Markdown
Contributor
diemilio
commented
Jul 10, 2024
diemilio
commented
fixes #1025 by renaming the incorrectly used types attribute of TimeResponseData objects to trace_types
diemilio
changed the title
Update timeplot.py
Fix wrong attribute name in control.combine_time_responses function
diemilio
changed the title
Fix wrong attribute name in
Fix incorrect attribute name in control.combine_time_responses functioncontrol.combine_time_responses function
Copy link Copy Markdown
coveralls
commented
Jul 10, 2024
coveralls commented
Jul 10, 2024
Copy link Copy Markdown
Member
slivingston
commented
Jul 10, 2024
slivingston commented
Jul 10, 2024@diemilio Thanks! Can you add a regression test that demonstrates the bug?
murrayrm
closed this
murrayrm
force-pushed
the
main
branch
from
70d9761 to
bb82883
Compare
Copy link Copy Markdown
Member
murrayrm
commented
Jul 13, 2024
murrayrm commented
Jul 13, 2024Not quite sure what happened, but I didn't mean to close this...
I added a regression test. Need to figure out how to retrieve it (apologies @diemilio!).
murrayrm
mentioned this pull request
Merged
Copy link Copy Markdown
Contributor Author
diemilio
commented
Jul 13, 2024
diemilio commented
Jul 13, 2024No problem. Sorry I could not get to add the tests earlier, so thanks for adding this.
murrayrm
added this to the
0.10.1 milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants