Extend returnScipySignalLTI() to discrete systems by bnavigator · Pull Request #445 · python-control/python-control
Navigation Menu
{{ message }}
python-control / python-control Public
- Notifications You must be signed in to change notification settings
- Fork 453
Merged
bnavigator merged 1 commit intopython-control:masterfrom
Dec 29, 2020Merged
Extend returnScipySignalLTI() to discrete systems#445
bnavigator merged 1 commit intopython-control:masterfrom
Extend returnScipySignalLTI() to discrete systems#445
bnavigator merged 1 commit intopython-control:masterfrom
Conversation
Copy link Copy Markdown
Contributor
These were not covered by the tests, so I wrote some tests and found out it is not that hard to extend them to discrete systems.
bnavigator
force-pushed
the
extend-tf2scipylti
branch
from
cf0b866 to
a8aa41e
Compare
Copy link Copy Markdown
Copy link Copy Markdown
coveralls
commented
Aug 2, 2020
coveralls commented
Aug 2, 2020
bnavigator
mentioned this pull request
bnavigator
added this to the
0.9.0 milestone
Copy link Copy Markdown
Contributor
sawyerbfuller
commented
Aug 20, 2020
sawyerbfuller commented
Aug 20, 2020Returning a cont-time scipy system when dt=None seems like a reasonable choice (I think in scipy, dt=None actually means cont time).
sawyerbfuller approved these changes Aug 20, 2020
Copy link Copy Markdown
Contributor
sawyerbfuller
left a comment
sawyerbfuller
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment
bnavigator
force-pushed
the
extend-tf2scipylti
branch
from
a3336a4 to
edd29fd
Compare
Copy link Copy Markdown
Contributor Author
bnavigator
commented
Aug 20, 2020
bnavigator commented
Aug 20, 2020Re current CI fail: #456
bnavigator
added
the
enhancement
label
bnavigator
force-pushed
the
extend-tf2scipylti
branch
from
edd29fd to
1e7c714
Compare
bnavigator
force-pushed
the
extend-tf2scipylti
branch
from
1e7c714 to
86069d0
Compare
and add unit tests
bnavigator
force-pushed
the
extend-tf2scipylti
branch
from
86069d0 to
d6d77dc
Compare
bnavigator
merged commit
51c797e
into
python-control:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment