handle empty pole vector for timevector calculation by bnavigator · Pull Request #485 · python-control/python-control
Navigation Menu
{{ message }}
python-control / python-control Public
- Notifications You must be signed in to change notification settings
- Fork 453
Merged
murrayrm merged 1 commit intopython-control:masterfrom
Dec 30, 2020Merged
handle empty pole vector for timevector calculation#485
murrayrm merged 1 commit intopython-control:masterfrom
handle empty pole vector for timevector calculation#485
murrayrm merged 1 commit intopython-control:masterfrom
Conversation
Copy link Copy Markdown
Contributor
bnavigator
commented
Dec 29, 2020
bnavigator
commented
- The automatic timevector calculation sometimes encounters empty vectors. The small random systems used in the test suite sometimes fail (Refactor the test suite using pytest for array and matrix types #438).
- Escape the LaTeX formula in the docstring to avoid warning messages. Sphinx can still handle it.
bnavigator
mentioned this pull request
Copy link Copy Markdown
bnavigator
requested a review
from sawyerbfuller
bnavigator
mentioned this pull request
murrayrm approved these changes Dec 30, 2020
Copy link Copy Markdown
Member
murrayrm
left a comment
murrayrm
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks fine. The code itself could use some documentation and the reuse of m_u as a subset of p_u is confusing, but not something that needs to be fixed here.
murrayrm
merged commit
4eee1f3
into
python-control:master
bnavigator
deleted the
timevector-fix
branch
murrayrm
added this to the
0.9.0 milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants