Fix loading of defaults during pytest fixture setup by bnavigator · Pull Request #489 · python-control/python-control
Navigation Menu
{{ message }}
python-control / python-control Public
- Notifications You must be signed in to change notification settings
- Fork 453
Merged
bnavigator merged 1 commit intopython-control:masterfrom
Dec 31, 2020Merged
Fix loading of defaults during pytest fixture setup#489
bnavigator merged 1 commit intopython-control:masterfrom
Fix loading of defaults during pytest fixture setup#489
bnavigator merged 1 commit intopython-control:masterfrom
Conversation
Copy link Copy Markdown
Contributor
bnavigator
commented
Dec 30, 2020
bnavigator
commented
Also make matarrayout and matarrayin function scoped fixtures so
that they can set the warnings filters individually as needed for
each test.
Fixes #488
Also make matarrayout and matarrayin function scoped fixtures so that they can set the warnings filters individually as needed for each test.
Copy link Copy Markdown
coveralls
commented
Dec 30, 2020
coveralls commented
Dec 30, 2020
Copy link Copy Markdown
Copy link Copy Markdown
Member
murrayrm
commented
Dec 31, 2020
murrayrm commented
Dec 31, 2020I'm not enough of a pytest guru (yet -:) to understand this in detail. OK by me to merge unless you feel that someone else should have a closer look first.
Copy link Copy Markdown
Contributor Author
bnavigator
commented
Dec 31, 2020
bnavigator commented
Dec 31, 2020I think I tested it thoroughly on my local machine. Given that it affects only the test suite and not the end user I feel confident enough to merge it with "just" your OK.
Copy link Copy Markdown
Contributor Author
bnavigator
commented
Dec 31, 2020
bnavigator commented
Dec 31, 2020Meh, the 3 uncovered lines in freqplot need some investigation before merging.
bnavigator
mentioned this pull request
bnavigator
merged commit
bbb2e36
into
python-control:master
bnavigator
deleted the
fix-defaults
branch
murrayrm
added this to the
0.9.0 milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants