fix #523: finding z for |H(z)|=1 computed the wrong polynomials by bnavigator · Pull Request #525 · python-control/python-control

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@bnavigator

Copy link Copy Markdown

Contributor

Even the reference values for the tests were wrong.

@coveralls

Copy link Copy Markdown

coveralls commented

Jan 30, 2021

edited

Loading

Coverage Status

Coverage remained the same at 87.754% when pulling 48a18d6 on bnavigator:fix-523 into 6d51358 on python-control:master.

@bnavigator bnavigator merged commit 649215e into python-control:master

Jan 30, 2021

@murrayrm murrayrm added this to the 0.9.0 milestone

Mar 20, 2021

@bnavigator bnavigator deleted the fix-523 branch

February 18, 2024 20:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sawyerbfuller sawyerbfuller sawyerbfuller approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

stability_margins doesn't find gain=1 crossover frequency correctly for DT systems

4 participants

@bnavigator @coveralls @sawyerbfuller @murrayrm