support discrete system as input for FRD by bnavigator · Pull Request #568

support discrete system as input for FRD by bnavigator · Pull Request #568 · python-control/python-control

Triggered by #566 and #523, it was revealed that the evaluation of the sys parameter does not take into account discrete time systems.

Coverage decreased (-0.04%) to 88.821% when pulling fd80fc8 on bnavigator:discretesys2frd into 92de12d on python-control:master.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! One remark: FRD.__call__ only works with purely imaginary arguments of the form omega*1j, which I think is still what we want, right? The alternative is if an FRD system derived from a discrete time system that z must be on the unit circle. I think I favor the former but I am not positive that is the "right" way or not.

sawyerbfuller added a commit to sawyerbfuller/python-control that referenced this pull request

Mar 12, 2021

I also favor the current. Otherwise you would have to keep track from which kind you created the FRD system.