modify discrete-time contour for nyquist plots to indent around poles by sawyerbfuller · Pull Request #668 · python-control/python-control

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@sawyerbfuller

Copy link Copy Markdown

Contributor

@sawyerbfuller sawyerbfuller commented

Nov 5, 2021

edited

Loading

Completing a “todo” that was in the code, to make nyquist plots work better foe discrete-time systems (Continuous-time indentation was already in place )

@sawyerbfuller sawyerbfuller marked this pull request as draft

November 5, 2021 06:50

@coveralls

Copy link Copy Markdown

coveralls commented

Nov 5, 2021

edited

Loading

Coverage Status

Coverage increased (+0.01%) to 89.945% when pulling a948186 on sawyerbfuller:nyquist-discrete-indent into e9c224c on python-control:master.

…ane poles near imaginary axis are on imaginary axis

@sawyerbfuller sawyerbfuller marked this pull request as ready for review

November 5, 2021 19:02

@sawyerbfuller sawyerbfuller changed the title modify discrete-time contour for nyquist plots to indent around poles [WIP] modify discrete-time contour for nyquist plots to indent around poles

Nov 5, 2021
Copy link Copy Markdown

Contributor

@bnavigator bnavigator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sawyerbfuller sawyerbfuller merged commit affe4d3 into python-control:master

Nov 5, 2021

@murrayrm murrayrm added this to the 0.9.1 milestone

Dec 30, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnavigator bnavigator bnavigator approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.1

Development

Successfully merging this pull request may close these issues.

4 participants

@sawyerbfuller @coveralls @bnavigator @murrayrm