Fix timebase bug in InterconnectedSystem (issue #754) by murrayrm · Pull Request #755 · python-control/python-control

Skip to content

Navigation Menu

Sign in

Appearance settings

Conversation

@murrayrm

This PR fixes the timebase bug identified in issue #754. The fix was to modify the processing of the timebase in InterconnectedSystem so that it looks at the systems for the default timebase.

@murrayrm

Conda-based builds are failing. I checked and this is also happening on the current main branch. This may be something associated with Slycot 0.5.0??

sawyerbfuller

(None, 0.1, 0.1),
(None, None, None),
(0.2, None, 0.2),
(0.2, 0.1, ValueError),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestion. Done.

@coveralls

Coverage Status

Coverage increased (+0.0008%) to 94.654% when pulling cf30479 on murrayrm:timebase_bug-03Aug2022 into a73a03d on python-control:main.