fix control.matlab.lsim bug for discrete time system by murrayrm · Pull Request #765 · python-control/python-control
Navigation Menu
{{ message }}
python-control / python-control Public
- Notifications You must be signed in to change notification settings
- Fork 453
Merged
bnavigator merged 2 commits intopython-control:mainfrom
Aug 25, 2022Merged
fix control.matlab.lsim bug for discrete time system#765
bnavigator merged 2 commits intopython-control:mainfrom
fix control.matlab.lsim bug for discrete time system#765
bnavigator merged 2 commits intopython-control:mainfrom
Conversation
Copy link Copy Markdown
Member
This PR fixes issue #764. There was a dimension check in forced_response for discrete time systems that occurred before processing of the transpose parameter. Removing the dimension check (which gets done later, after transpose processing) fixes the bug. Add a unit test to catch the error and also turned on some tests that were @slycotonly but that didn't rely on slycot.
murrayrm added 2 commits
August 24, 2022 21:09
Copy link Copy Markdown
coveralls
commented
Aug 25, 2022
coveralls commented
Aug 25, 2022
Copy link Copy Markdown
Contributor
bnavigator
commented
Aug 25, 2022
bnavigator commented
Aug 25, 2022LGTM, thanks!
bnavigator
merged commit
59aeceb
into
python-control:main
bnavigator
mentioned this pull request
murrayrm
added this to the
0.9.3 milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants