Fix find_eqpt when y0 is None by adswid · Pull Request #798 · python-control/python-control

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@adswid

Copy link Copy Markdown

Contributor

@adswid adswid commented

Nov 24, 2022

When y0 is None, dy in the root function should not be calculated (since it tries to subtract NoneType). In general, when y0 is None, the evaluation of the output function is not necessary.

@coveralls

Copy link Copy Markdown

Coverage Status

Coverage increased (+0.001%) to 94.842% when pulling 57ad2f1 on adswid:fix-find_eqpt into 832527d on python-control:main.

@murrayrm

Copy link Copy Markdown

Member

murrayrm commented

Nov 26, 2022

edited

Loading

LGTM. Thanks for the fix, @adswid!

@murrayrm murrayrm merged commit 23a7791 into python-control:main

Nov 26, 2022

@murrayrm murrayrm added this to the 0.9.3 milestone

Dec 24, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.3

Development

Successfully merging this pull request may close these issues.

3 participants

@adswid @coveralls @murrayrm