Fix Interconnect name clobbering by henklaak · Pull Request #857 · python-control/python-control

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

bnavigator merged 1 commit intopython-control:mainfrom

henklaak:main

Feb 2, 2023

Merged

Fix Interconnect name clobbering#857

bnavigator merged 1 commit intopython-control:mainfrom

henklaak:main

Conversation

@henklaak

Copy link Copy Markdown

Contributor

@henklaak henklaak commented

Feb 1, 2023

iosys interconnect implementation clobbers the name argument of the function.
Fix by renaming to a name that is only used locally

@henklaak

Copy link Copy Markdown

Contributor Author

henklaak commented

Feb 1, 2023

edited

Loading

Fixes #848

Overlap with #849, but that one doesn't come with unittests ;-)

@coveralls

Copy link Copy Markdown

Coverage Status

Coverage: 94.87%. Remained the same when pulling 5f2e758 on henklaak:main into 1f837a5 on python-control:main.

@bnavigator

Copy link Copy Markdown

Contributor

Thanks. Will rebase #849.

henklaak reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.4

Development

Successfully merging this pull request may close these issues.

create_statefbk_iosystem sets system name incorrectly

4 participants

@henklaak @coveralls @bnavigator @murrayrm