Solve #862 and #864: bode_plot phase wrapping incorrect for multiple systems by henklaak · Pull Request #863 · python-control/python-control

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@henklaak

Copy link Copy Markdown

Contributor

Function argument clobbered by local assignment. Use local variable instead.

@henklaak

Copy link Copy Markdown

Contributor Author

henklaak commented

Feb 17, 2023

edited

Loading

matplotlib 3.6.3 => 3.7.* seems to break our tests. Will investigate further.

@henklaak

Copy link Copy Markdown

Contributor Author

Solves #862 and #864. If you prefer, I can make separate PRs.

@henklaak henklaak changed the title Solve #862: bode_plot phase wrapping incorrect for multiple systems Solve #862 and #864: bode_plot phase wrapping incorrect for multiple systems

Feb 17, 2023

@coveralls

Copy link Copy Markdown

Coverage Status

Coverage: 94.872%. Remained the same when pulling 4c4b3fc on henklaak:main into c4d1764 on python-control:main.

@murrayrm

Copy link Copy Markdown

Member

Thanks for the fixes!

@murrayrm murrayrm merged commit 346bc40 into python-control:main

Feb 18, 2023

@murrayrm murrayrm added this to the 0.9.4 milestone

Mar 27, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.4

Development

Successfully merging this pull request may close these issues.

3 participants

@henklaak @coveralls @murrayrm