Fix TimeResponseData.to_pandas() to handle zero state case by murrayrm · Pull Request #958 · python-control/python-control

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@murrayrm

Copy link Copy Markdown

Member

@murrayrm murrayrm commented

Jan 4, 2024

Fixes issue #957.

@coveralls

Copy link Copy Markdown

Coverage Status

coverage: 94.991% (+0.002%) from 94.989%
when pulling 6a8779c on murrayrm:to_pandas_bug-03Jan2024
into b389b64 on python-control:main.

Copy link Copy Markdown

Contributor

@joaoantoniocardoso joaoantoniocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested here, thanks! :)

@bnavigator

Copy link Copy Markdown

Contributor

LGTM

@bnavigator bnavigator merged commit 6ed2e77 into python-control:main

Jan 10, 2024

@murrayrm murrayrm added this to the 0.10.0 milestone

Mar 31, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@joaoantoniocardoso joaoantoniocardoso joaoantoniocardoso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.0

Development

Successfully merging this pull request may close these issues.

TimeResponseData.to_pandas() fails if there are no states in a NonlinearIOSystem

4 participants

@murrayrm @coveralls @bnavigator @joaoantoniocardoso