Fix examples by bnavigator · Pull Request #965 · python-control/python-control

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@bnavigator

Copy link Copy Markdown

Contributor

Conda deployed scipy 1.12 and the examples job started to fail with

ImportError: cannot import name 'pi' from 'scipy'

  • Use the officially documented NumPy API instead.
  • Use the opportunity to escape two unescaped strings with LaTeX formatted labels.

@coveralls

Copy link Copy Markdown

coveralls commented

Jan 22, 2024

edited

Loading

Coverage Status

coverage: 94.784%. remained the same
when pulling 2c32913 on bnavigator:fix-examples
into a8a54d1 on python-control:main.

@bnavigator bnavigator marked this pull request as ready for review

January 22, 2024 20:58

@murrayrm

Copy link Copy Markdown

Member

LGTM.

@bnavigator bnavigator merged commit 85328d9 into python-control:main

Jan 23, 2024

@bnavigator bnavigator mentioned this pull request

Jan 28, 2024

@murrayrm murrayrm added this to the 0.10.0 milestone

Mar 31, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@bnavigator @coveralls @murrayrm