Switched from deprecated "setup.py install" to "pip install ." by radarhere · Pull Request #5896 · python-pillow/Pillow
Conversation
Copy link Copy Markdown
Member
radarhere
commented
Dec 18, 2021
radarhere
commented
Replaces setup.py install with pip install ., as per https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html
As worked out by pypa/setuptools#2929, this also fixes the problem found in #5886. So this PR reverts #5886 and #5888.
radarhere added 2 commits
December 18, 2021 19:39Copy link Copy Markdown
Member
hugovk
commented
Dec 18, 2021
hugovk commented
Dec 18, 2021Good stuff!
There's some setup.py develop as well, can they be pip install -e?
Also some setup.py build, setup.py build_ext and setup.py clean but they can wait.
Copy link Copy Markdown
Member Author
radarhere
commented
Dec 19, 2021
radarhere commented
Dec 19, 2021Ok, done.
Copy link Copy Markdown
Member
hugovk
commented
Dec 19, 2021
hugovk commented
Dec 19, 2021Thanks!
hugovk
merged commit
0badf97
into
python-pillow:main
radarhere
deleted the
pip_install
branch
radarhere
mentioned this pull request
radarhere
mentioned this pull request
radarhere
mentioned this pull request
hugovk
mentioned this pull request
hugovk
mentioned this pull request
radarhere
mentioned this pull request
radarhere
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment