Switched from deprecated "setup.py install" to "pip install ." by radarhere · Pull Request #5896 · python-pillow/Pillow

Conversation

@radarhere

Copy link Copy Markdown

Member

Replaces setup.py install with pip install ., as per https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html

As worked out by pypa/setuptools#2929, this also fixes the problem found in #5886. So this PR reverts #5886 and #5888.

aclark4life reacted with hooray emoji

@hugovk

Copy link Copy Markdown

Member

hugovk commented

Dec 18, 2021

Good stuff!

There's some setup.py develop as well, can they be pip install -e?

Also some setup.py build, setup.py build_ext and setup.py clean but they can wait.

@radarhere

Copy link Copy Markdown

Member Author

Ok, done.

hugovk reacted with hooray emoji

@hugovk

Copy link Copy Markdown

Member

hugovk commented

Dec 19, 2021

Thanks!

@hugovk hugovk merged commit 0badf97 into python-pillow:main

Dec 19, 2021

@radarhere radarhere deleted the pip_install branch

December 19, 2021 20:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@radarhere @hugovk