Add type hints to ContainerIO by nulano · Pull Request #7656 · python-pillow/Pillow

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@nulano

Copy link Copy Markdown

Contributor

@nulano nulano commented

Dec 29, 2023

edited by hugovk

Loading

Helps #2625.

The two ignore comments are required because mypy doesn't know that "b" in self.fh.mode if and only if self is a ContainerIO[bytes] rather than a ContainerIO[str].

@radarhere radarhere merged commit 42c574a into python-pillow:main

Dec 31, 2023

@nulano nulano deleted the types-containerio branch

December 31, 2023 13:26

@hugovk hugovk changed the title Add type hints to PIL.ContainerIO Add type hints to ContainerIO

Dec 31, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@radarhere radarhere radarhere left review comments

@hugovk hugovk hugovk approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nulano @hugovk @radarhere