Use consistent arguments for load_read and load_seek by radarhere · Pull Request #7713 · python-pillow/Pillow
Navigation Menu
{{ message }}
python-pillow / Pillow Public
- Notifications You must be signed in to change notification settings
- Fork 2.4k
Merged
Use consistent arguments for load_read and load_seek#7713
hugovk merged 2 commits intopython-pillow:mainfrom
Use consistent arguments for load_read and load_seek#7713
hugovk merged 2 commits intopython-pillow:mainfrom
Conversation
Copy link Copy Markdown
Member
radarhere
commented
Jan 13, 2024
radarhere
commented
load_read() does not have a consistent signature across the plugins where it is used. For example,
Pillow/src/PIL/JpegImagePlugin.py
Line 411 in 9923531
| def load_read(self, read_bytes): |
Pillow/src/PIL/XpmImagePlugin.py
Line 106 in 9923531
| def load_read(self, bytes): |
Neither does load_seek(). For example,
Pillow/src/PIL/FtexImagePlugin.py
Line 105 in 9923531
| def load_seek(self, pos): |
Pillow/src/PIL/IcoImagePlugin.py
Line 342 in 9923531
| def load_seek(self): |
radarhere added 2 commits
January 13, 2024 21:10
radarhere
added
the
Cleanup
label
hugovk
merged commit
80fd507
into
python-pillow:main
radarhere
deleted the
load
branch
data-sync-user
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment