Added type hints to additional tests by radarhere · Pull Request #7816 · python-pillow/Pillow
Navigation Menu
{{ message }}
python-pillow / Pillow Public
- Notifications You must be signed in to change notification settings
- Fork 2.4k
Merged
radarhere merged 3 commits intopython-pillow:mainfrom
Feb 20, 2024Merged
Added type hints to additional tests#7816
radarhere merged 3 commits intopython-pillow:mainfrom
Added type hints to additional tests#7816
radarhere merged 3 commits intopython-pillow:mainfrom
Conversation
radarhere
added
the
Type hints
label
hugovk approved these changes Feb 20, 2024
Tests/test_imagecms.py
Outdated
Show resolved
Hide resolved
Tests/test_imagecms.py Outdated Show resolved Hide resolved
hugovk reviewed Feb 20, 2024
Tests/test_imagecms.py
Outdated
Tests/test_imagecms.py Outdated
| | tuple[float, ...] | ||
| ) | ||
| ) -> tuple[tuple[float, ...], ...]: | ||
| def truncate_tuple(tuple_or_float: tuple[Any, ...]) -> tuple[Any, ...]: |
Copy link Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This parameter is called tuple_or_float but typed only as a tuple.
Do we ever call it as a float? If not, shall we rename it?
Copy link Copy Markdown
Member Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed a commit to rename it to tuple_value.
nulano
mentioned this pull request
hugovk approved these changes Feb 20, 2024
radarhere
merged commit
b9d3c21
into
python-pillow:main
radarhere
deleted the
type_hints
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment