Updated xz to 5.6.2 by radarhere · Pull Request #7916 · python-pillow/Pillow

@radarhere

@nulano

I'm assuming you are aware of CVE-2024-3094 and didn't upgrade to 5.6.1 for that reason. Perhaps it is an overreaction at this point, but I'm wondering if we should consider completely removing liblzma from the wheels for the upcoming release. liblzma is only an indirect optional dependency via libtiff and users could just install from source if they need it.

@wiredfool

@hugovk hugovk marked this pull request as draft

March 30, 2024 20:17

@radarhere

@radarhere radarhere changed the title Updated xz to 5.4.6 Updated xz to 5.6.2

May 29, 2024

@radarhere

@radarhere radarhere marked this pull request as ready for review

May 29, 2024 23:57

@nulano

Should we also switch to using the GitHub release instead of SourceForge?

"url": f"{SF_PROJECTS}/lzmautils/files/xz-{V['XZ']}.tar.gz/download",

Multibuild uses https://tukaani.org/xz/xz-5.6.2.tar.gz which is a redirect to the GitHub release:

C:\Users\Nulano>curl --head https://tukaani.org/xz/xz-5.6.2.tar.gz
HTTP/1.1 302 Found
Server: nginx
Date: Wed, 12 Jun 2024 18:51:24 GMT
Content-Type: text/html; charset=iso-8859-1
Content-Length: 262
Connection: keep-alive
Location: https://github.com/tukaani-project/xz/releases/download/v5.6.2/xz-5.6.2.tar.gz
X-Proxy-Cache: BYPASS
X-Powered-By: Zoner

@radarhere

@radarhere

Ok, GitHub does look to be the primary repository. I've pushed a commit.

@hugovk

My thinking on this: I don't see anything particularly urgent/important in the changelog to merge this right now, so maybe we hold off for another release or so?

@radarhere

Another release or so of ours, or of xz? I'm guessing you mean xz, as a way of increasing confidence that they have reviewed their code thoroughly.

@hugovk

Of ours, but that could also include of xz :)

Yeah, I don't think we're in a rush to upgrade, and it gives some more time for the dust to settle.

@hugovk

More time has passed and things have settled. Any objections to merging this for our release next month?

@radarhere