Use functools.cached_property in ImageStat by nulano · Pull Request #7952 · python-pillow/Pillow

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@nulano

Copy link Copy Markdown

Contributor

@nulano nulano commented

Apr 7, 2024

Changes proposed to ImageStat in this pull request:

  • Replace custom caching with functools.cached_property
  • Add type hints.
  • Move documentation from rst file to docstrings to include type hints in docs.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>

@hugovk hugovk merged commit 0e90c1c into python-pillow:main

Apr 16, 2024

@hugovk

Copy link Copy Markdown

Member

hugovk commented

Apr 16, 2024

Thanks!

@nulano nulano deleted the types-imagestat branch

April 16, 2024 18:04

@radarhere radarhere changed the title Use functools.cached_property and add type hints to ImageStat Use functools.cached_property in ImageStat

Apr 22, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments

@radarhere radarhere radarhere approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nulano @hugovk @radarhere