Simplified RGB to I;16, I;16L and I;16B conversion by radarhere · Pull Request #8008 · python-pillow/Pillow

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@radarhere

Copy link Copy Markdown

Member

@radarhere radarhere commented

Apr 24, 2024

edited

Loading

Discussion at fb6b860#r141279400 has revealed that when converting from RGB to an I;16* mode, the result is not going to be larger than 8 bits, and so the code can be simplified.

Copy link Copy Markdown

Contributor

@lukegb lukegb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the cleanup!

@hugovk hugovk added the Cleanup label

Apr 24, 2024

@hugovk hugovk merged commit 1fc1179 into python-pillow:main

Apr 24, 2024

@radarhere radarhere deleted the convert branch

April 24, 2024 22:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@lukegb lukegb lukegb approved these changes

@nulano nulano nulano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@radarhere @lukegb @nulano @hugovk