Use common test scripts for more tests by Yay295 · Pull Request #8396 · python-pillow/Pillow
Add a CI test script for Windows, and update appveyor, mingw, and windows to use the common test scripts.
| - '%PYTHON%\%EXECUTABLE% -m pytest -vx --cov PIL --cov Tests --cov-report term --cov-report xml Tests' | ||
| #- '%PYTHON%\%EXECUTABLE% test-installed.py -v -s %TEST_OPTIONS%' TODO TEST_OPTIONS with pytest? | ||
| - PATH %PYTHON%;%PATH% | ||
| - .ci\test.cmd |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. A minor concern perhaps, but your new version uses a hardcoded value for the Python executable, rather than the configuration from earlier in the file.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the test environments use a hardcoded executable name, and even in this file %EXECUTABLE% is always python.exe.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some unexpected skipped tests, but that is caused by #8302, not this PR.
Yay295
deleted the
common_test_script
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters