Change harfbuzz versions in wheels by radarhere · Pull Request #8421 · python-pillow/Pillow
Navigation Menu
{{ message }}
python-pillow / Pillow Public
- Notifications You must be signed in to change notification settings
- Fork 2.4k
Merged
hugovk merged 3 commits intopython-pillow:mainfrom
Sep 27, 2024Merged
Change harfbuzz versions in wheels#8421
hugovk merged 3 commits intopython-pillow:mainfrom
Change harfbuzz versions in wheels#8421
hugovk merged 3 commits intopython-pillow:mainfrom
Conversation
Copy link Copy Markdown
Member
Two changes here.
- As noted in Updated harfbuzz to 9.0.0 in wheels, except for manylinux2014 #8361, harfbuzz has switched to meson - https://github.com/harfbuzz/harfbuzz/releases/tag/9.0.0.
More specifically though, it now requires meson >= 0.55.
This is a problem, as the base image for oss-fuzz uses Ubuntu 20.04, which only has meson 0.53.2
So this PR downgrades harfuzz on OSS Fuzz to the version before meson became mandatory. I've used the environment variable 'SANITIZER' to detect OSS Fuzz.
- I found that harfbuzz 8.5.0 was being installed on macOS. I've fixed that, and 10.0.1 is now installed instead.
radarhere added 3 commits
September 27, 2024 14:59Copy link Copy Markdown
Member
hugovk
commented
Sep 27, 2024
hugovk commented
Sep 27, 2024Here's an issue about upgrading Ubuntu in the base image: google/oss-fuzz#11835
hugovk
merged commit
86b42a9
into
python-pillow:main
radarhere
deleted the
harfbuzz
branch
Copy link Copy Markdown
khaledhosny
commented
Sep 28, 2024
khaledhosny commented
Sep 28, 2024You can pip install meson on oss-fuzz build scripts, that is how we build HarfBuzz there (you might also want to bin meson version to a known working one, since new meson versions sometimes break build, at least in the past).
radarhere
mentioned this pull request
Copy link Copy Markdown
Member Author
radarhere
commented
Sep 28, 2024
radarhere commented
Sep 28, 2024Thanks for the suggestion! I've created #8424
radarhere
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment