Change harfbuzz versions in wheels by radarhere · Pull Request #8421 · python-pillow/Pillow

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@radarhere

Copy link Copy Markdown

Member

@radarhere radarhere commented

Sep 27, 2024

edited

Loading

Two changes here.

  1. As noted in Updated harfbuzz to 9.0.0 in wheels, except for manylinux2014 #8361, harfbuzz has switched to meson - https://github.com/harfbuzz/harfbuzz/releases/tag/9.0.0.

More specifically though, it now requires meson >= 0.55.

This is a problem, as the base image for oss-fuzz uses Ubuntu 20.04, which only has meson 0.53.2

So this PR downgrades harfuzz on OSS Fuzz to the version before meson became mandatory. I've used the environment variable 'SANITIZER' to detect OSS Fuzz.

  1. I found that harfbuzz 8.5.0 was being installed on macOS. I've fixed that, and 10.0.1 is now installed instead.

@hugovk

Copy link Copy Markdown

Member

hugovk commented

Sep 27, 2024

Here's an issue about upgrading Ubuntu in the base image: google/oss-fuzz#11835

@hugovk hugovk merged commit 86b42a9 into python-pillow:main

Sep 27, 2024

@radarhere radarhere deleted the harfbuzz branch

September 28, 2024 00:10

@khaledhosny

Copy link Copy Markdown

You can pip install meson on oss-fuzz build scripts, that is how we build HarfBuzz there (you might also want to bin meson version to a known working one, since new meson versions sometimes break build, at least in the past).

@radarhere

Copy link Copy Markdown

Member Author

Thanks for the suggestion! I've created #8424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@radarhere @hugovk @khaledhosny