Do not repeatedly save to the same path by radarhere · Pull Request #8512 · python-pillow/Pillow
Navigation Menu
{{ message }}
python-pillow / Pillow Public
- Notifications You must be signed in to change notification settings
- Fork 2.4k
Merged
hugovk merged 2 commits intopython-pillow:mainfrom
Oct 29, 2024Merged
Do not repeatedly save to the same path#8512
hugovk merged 2 commits intopython-pillow:mainfrom
Do not repeatedly save to the same path#8512
hugovk merged 2 commits intopython-pillow:mainfrom
Conversation
Copy link Copy Markdown
Member
radarhere
commented
Oct 29, 2024
radarhere
commented
tonybaloney/pytest-freethreaded#11 noted a segfault that can occur under free-threading with Tests/test_file_jpeg.py::test_qtables. I can replicate this with --require-gil-disabled - https://github.com/radarhere/Pillow/actions/runs/11572743510
Changing the test to save to a BytesIO instance rather than writing repeatedly to the same temporary path fixes this specific test - https://github.com/radarhere/Pillow/actions/runs/11572819452
hugovk reviewed Oct 29, 2024
Tests/test_file_jpeg.py
Outdated
Show resolved
Hide resolved
Tests/test_file_jpeg.py Outdated Show resolved Hide resolved
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk
merged commit
16372dd
into
python-pillow:main
radarhere
deleted the
qtables
branch
radarhere
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment