Removed condition that is always true by radarhere · Pull Request #8862 · python-pillow/Pillow
Navigation Menu
{{ message }}
python-pillow / Pillow Public
- Notifications You must be signed in to change notification settings
- Fork 2.4k
Merged
hugovk merged 1 commit intopython-pillow:mainfrom
Apr 3, 2025Merged
Removed condition that is always true#8862
hugovk merged 1 commit intopython-pillow:mainfrom
Removed condition that is always true#8862
hugovk merged 1 commit intopython-pillow:mainfrom
Conversation
Copy link Copy Markdown
Member
https://github.com/python-pillow/Pillow/actions/runs/14220077307/job/39845672092#step:10:365
src/_avif.c:571:10: warning: address of 'rgb' will always evaluate to 'true' [-Wpointer-bool-conversion]
if (&rgb) {
~~ ^~~
cc @fdintino
fdintino approved these changes Apr 2, 2025
Copy link Copy Markdown
Contributor
fdintino
left a comment
fdintino
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. I think this got added in the refactor that added the goto; I noticed the warning and had intended to fix it, but it slipped my mind.
radarhere
deleted the
avif_rgb
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants