Add Parameter `read_file_handle` to `InputFile` by Bibo-Joshi · Pull Request #4388 · python-telegram-bot/python-telegram-bot
Navigation Menu
{{ message }}
python-telegram-bot / python-telegram-bot Public
- Notifications You must be signed in to change notification settings
- Fork 6k
Merged
Add Parameter read_file_handle to InputFile#4388
Bibo-Joshi merged 10 commits intomasterfrom
Add Parameter read_file_handle to InputFile#4388
Bibo-Joshi merged 10 commits intomasterfrom
Conversation
Bibo-Joshi added 3 commits
July 17, 2024 21:57
Bibo-Joshi
added
bug 🐛
labels
Bibo-Joshi
mentioned this pull request
Bibo-Joshi added 2 commits
July 21, 2024 21:16# Conflicts: # telegram/_files/inputfile.py
Bibo-Joshi
mentioned this pull request
Bibo-Joshi added 3 commits
July 21, 2024 22:03
Bibo-Joshi
marked this pull request as ready for review
harshil21 reviewed Aug 1, 2024
Copy link
Member
harshil21
left a comment
harshil21
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should also edit the wiki page to mention this, it can be easily overlooked.
tests/request/test_request.py
Outdated
Show resolved
Hide resolved
tests/request/test_request.py Outdated Show resolved Hide resolved
Bibo-Joshi added 2 commits
August 2, 2024 13:44
Copy link
Member Author
Bibo-Joshi
commented
Aug 2, 2024
Bibo-Joshi commented
Aug 2, 2024we should also edit the wiki page to mention this, it can be easily overlooked.
good point. Added notes at
https://github.com/python-telegram-bot/dev-wiki/wiki/Working-with-Files-and-Media
and
https://github.com/python-telegram-bot/dev-wiki/wiki/Local-Bot-API-Server
harshil21 approved these changes Aug 2, 2024
Bibo-Joshi
merged commit
3a49372
into
master
Bibo-Joshi
deleted the
bug/large-files
branch
github-actions
bot
locked and limited conversation to collaborators
Bibo-Joshi
added
🔌 bug
and removed bug 🐛 labels
Nov 3, 2024This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.