Correctly preserve exception __context__ in MultiError.catch by njsmith · Pull Request #165 · python-trio/trio
Navigation Menu
{{ message }}
python-trio / trio Public
- Notifications You must be signed in to change notification settings
- Fork 391
Merged
njsmith merged 1 commit intopython-trio:masterfrom
May 19, 2017Merged
Correctly preserve exception __context__ in MultiError.catch#165
njsmith merged 1 commit intopython-trio:masterfrom
Correctly preserve exception __context__ in MultiError.catch#165
njsmith merged 1 commit intopython-trio:masterfrom
Conversation
Copy link
Member
njsmith
commented
May 19, 2017
njsmith
commented
Python's implicit exception chaining logic insists on corrupting
context when we re-raise an unpacked exception in
MultiError.catch. This commit introduces a counter-measure.
Python's implicit exception chaining logic insists on corrupting __context__ when we re-raise an unpacked exception in MultiError.catch. This commit introduces a counter-measure.
njsmith
mentioned this pull request
Copy link
Codecov Report
Merging #165 into master will decrease coverage by
0.02%.
The diff coverage is100%.
@@ Coverage Diff @@ ## master #165 +/- ## ========================================= - Coverage 98.43% 98.4% -0.03% ========================================= Files 51 51 Lines 5939 5960 +21 Branches 468 470 +2 ========================================= + Hits 5846 5865 +19 - Misses 79 80 +1 - Partials 14 15 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| trio/_core/_multierror.py | 100% <100%> (ø) |
⬆️ |
| trio/_core/tests/test_multierror.py | 100% <100%> (ø) |
⬆️ |
| trio/_util.py | 81.35% <0%> (-3.39%) |
⬇️ |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 0cac9f6...a2af710. Read the comment docs.
Copy link
Member Author
njsmith
commented
May 19, 2017
njsmith commented
May 19, 2017That's weird, appveyor seems to have just... not noticed this PR at all. It hasn't even attempted to build it. Maybe closing and opening again will make it notice?
njsmith
closed this
njsmith
reopened this
njsmith
merged commit
f64200c
into
python-trio:master
njsmith
deleted the
save-the-__context__
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant