maint: follows google's python style guide for docstrings by nandgator · Pull Request #224 · python-validators/validators

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@nandgator

Copy link Copy Markdown

Collaborator

@nandgator nandgator commented

Feb 16, 2023

edited

Loading

  • follows google's python style guide for docstrings
  • adds flake8-docstrings as dev dependency
  • update README's workflow badge
  • improves between.py and length.py scripts
  • adapts associated test cases as well
  • makes _extremes.py a private module

@nandgator nandgator added the review

PR: Can be reviewed

label

Feb 16, 2023

@nandgator nandgator self-assigned this

Feb 16, 2023

@kvesteri

Copy link Copy Markdown

Collaborator

Can you split this PR into smaller ones? That way it is easier to review the changes.

@nandgator

Copy link Copy Markdown

Collaborator Author

I can, but between.py, length.py and associated tests need to go together for the tests to be successful. Let me try moving other changes.

- follows Google's python style guide for docstrings
- adds flake8-docstrings as dev dependency
- update README's workflow badge

@nandgator

This comment was marked as duplicate.

@nandgator nandgator changed the title maint: improves between.py and length.py maint: follows google's python style guide for docstrings

Feb 16, 2023

@nandgator nandgator merged commit dab3a1f into python-validators:master

Feb 17, 2023

@nandgator nandgator removed the review

PR: Can be reviewed

label

Feb 17, 2023

@nandgator nandgator added the maintenance

PR: Alters existing source code

label

Mar 6, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nandgator nandgator

Labels

maintenance

PR: Alters existing source code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nandgator @kvesteri