fix: the equality checks for DNSPointer and DNSService should be case insensitive by bdraco · Pull Request #1122 · python-zeroconf/python-zeroconf
Conversation
Copy link Copy Markdown
Member
The name check is already using the key (lowercase value) but the server and alias did not use their respective keys
There are likely more cases where we don't handle this perfectly https://datatracker.ietf.org/doc/html/rfc4343#section-2
fixes #1121
bdraco added 2 commits
December 23, 2022 16:50
Copy link Copy Markdown
Codecov Report
Base: 99.72% // Head: 99.72% // Increases project coverage by +0.00% 🎉
Coverage data is based on head (
a00710d) compared to base (3a25ff7).
Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@ ## master #1122 +/- ## ======================================= Coverage 99.72% 99.72% ======================================= Files 22 22 Lines 2590 2591 +1 Branches 456 456 ======================================= + Hits 2583 2584 +1 Misses 5 5 Partials 2 2
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/zeroconf/__init__.py | 100.00% <100.00%> (ø) |
|
| src/zeroconf/_dns.py | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.
bdraco
marked this pull request as ready for review
bdraco
merged commit
48ae77f
into
master
bdraco
deleted the
equality_checks_caseless
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants