feat: speed up incoming data parser by bdraco · Pull Request #1161 · python-zeroconf/python-zeroconf
Navigation Menu
{{ message }}
python-zeroconf / python-zeroconf Public
- Notifications You must be signed in to change notification settings
- Fork 229
Merged
Conversation
Copy link Copy Markdown
Member
bdraco
commented
Apr 23, 2023
bdraco
commented
This is roughly a 4.5% speed up against the incoming benchmark
This is roughly a 4.5% speed up against the incoming benchmark
Copy link Copy Markdown
Codecov Report
Patch coverage: 100.00% and no project coverage change.
Comparison is base (
70719dd) 99.81% compared to head (43b2cae) 99.81%.
Additional details and impacted files
@@ Coverage Diff @@ ## master #1161 +/- ## ======================================= Coverage 99.81% 99.81% ======================================= Files 22 22 Lines 2652 2657 +5 Branches 463 464 +1 ======================================= + Hits 2647 2652 +5 Misses 3 3 Partials 2 2
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/zeroconf/_dns.py | 100.00% <100.00%> (ø) |
|
| src/zeroconf/_protocol/incoming.py | 98.88% <100.00%> (+0.01%) |
⬆️ |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.
Copy link Copy Markdown
Member Author
bdraco
commented
Apr 23, 2023
bdraco commented
Apr 23, 2023tested on a few production systems 👍
bdraco
merged commit
cb4c3b2
into
master
bdraco
deleted the
parser_speed
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant