feat: small speed up to fetch dns addresses from ServiceInfo by bdraco · Pull Request #1176 · python-zeroconf/python-zeroconf

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@bdraco

Copy link Copy Markdown

Member

@bdraco bdraco commented

May 25, 2023

No description provided.

@codecov

Copy link Copy Markdown

codecov bot commented

May 25, 2023

edited

Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (963d022) 99.81% compared to head (f40a190) 99.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1176   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          22       22           
  Lines        2673     2676    +3     
  Branches      465      465           
=======================================
+ Hits         2668     2671    +3     
  Misses          3        3           
  Partials        2        2           
Impacted Files Coverage Δ
src/zeroconf/__init__.py 100.00% <100.00%> (ø)
src/zeroconf/_services/info.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco marked this pull request as ready for review

May 25, 2023 12:45

@bdraco bdraco merged commit 4deaa6e into master

May 25, 2023

@bdraco bdraco deleted the dns_addresses branch

May 25, 2023 12:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bdraco