feat: reduce overhead to handle queries and responses by bdraco · Pull Request #1184 · python-zeroconf/python-zeroconf
Navigation Menu
{{ message }}
python-zeroconf / python-zeroconf Public
- Notifications You must be signed in to change notification settings
- Fork 229
Conversation
Copy link Copy Markdown
Member
bdraco
commented
Jun 15, 2023
bdraco
commented
-
adds slots to handler classes
-
avoid any expression overhead and inline instead
- adds slots to handler classes - avoid any expression overhead and inline instead
Copy link Copy Markdown
Codecov Report
Patch coverage: 100.00% and no project coverage change.
Comparison is base (
9ecce3a) 99.81% compared to head (02ea43e) 99.81%.
Additional details and impacted files
@@ Coverage Diff @@ ## master #1184 +/- ## ======================================= Coverage 99.81% 99.81% ======================================= Files 22 22 Lines 2709 2717 +8 Branches 471 472 +1 ======================================= + Hits 2704 2712 +8 Misses 3 3 Partials 2 2
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/zeroconf/__init__.py | 100.00% <100.00%> (ø) |
|
| src/zeroconf/_handlers.py | 100.00% <100.00%> (ø) |
☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.
Copy link Copy Markdown
Member Author
bdraco
commented
Jun 17, 2023
bdraco commented
Jun 17, 2023List comps are going to get a lot faster in 3.12 via https://peps.python.org/pep-0709/ but any and all don’t seem to be included
bdraco
marked this pull request as ready for review
bdraco
merged commit
81126b7
into
master
bdraco
deleted the
slots
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant