fix: reduce debug logging overhead by adding missing checks to datagram_received by bdraco · Pull Request #1188 · python-zeroconf/python-zeroconf
Navigation Menu
{{ message }}
python-zeroconf / python-zeroconf Public
- Notifications You must be signed in to change notification settings
- Fork 229
Merged
fix: reduce debug logging overhead by adding missing checks to datagram_received#1188
fix: reduce debug logging overhead by adding missing checks to datagram_received#1188
Conversation
Copy link Copy Markdown
Member
bdraco
commented
Jun 18, 2023
bdraco
commented
I only noticed these were missing when I ran the profiler on a system with IPv6
…am_received I only noticed these were missing when I ran the profiler on a system with IPv6
Copy link Copy Markdown
Codecov Report
Patch coverage: 100.00% and no project coverage change.
Comparison is base (
81126b7) 99.81% compared to head (2a12dda) 99.81%.
Additional details and impacted files
@@ Coverage Diff @@ ## master #1188 +/- ## ======================================= Coverage 99.81% 99.81% ======================================= Files 22 22 Lines 2717 2719 +2 Branches 472 474 +2 ======================================= + Hits 2712 2714 +2 Misses 3 3 Partials 2 2
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/zeroconf/__init__.py | 100.00% <100.00%> (ø) |
|
| src/zeroconf/_core.py | 100.00% <100.00%> (ø) |
☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.
bdraco added 2 commits
June 18, 2023 14:59
bdraco
merged commit
ac5c50a
into
master
bdraco
deleted the
debug_checks
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment