fix: reduce debug logging overhead by adding missing checks to datagram_received by bdraco · Pull Request #1188 · python-zeroconf/python-zeroconf

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@bdraco

Copy link Copy Markdown

Member

@bdraco bdraco commented

Jun 18, 2023

I only noticed these were missing when I ran the profiler on a system with IPv6

…am_received

I only noticed these were missing when I ran the profiler
on a system with IPv6

@codecov

Copy link Copy Markdown

codecov bot commented

Jun 18, 2023

edited

Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (81126b7) 99.81% compared to head (2a12dda) 99.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1188   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          22       22           
  Lines        2717     2719    +2     
  Branches      472      474    +2     
=======================================
+ Hits         2712     2714    +2     
  Misses          3        3           
  Partials        2        2           
Impacted Files Coverage Δ
src/zeroconf/__init__.py 100.00% <100.00%> (ø)
src/zeroconf/_core.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco merged commit ac5c50a into master

Jun 18, 2023

@bdraco bdraco deleted the debug_checks branch

June 18, 2023 20:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bdraco