feat: reorder incoming data handler to reduce overhead by bdraco · Pull Request #1189 · python-zeroconf/python-zeroconf
Conversation
Unpacks the address only after we know we are going to process the incoming message
…am_received I only noticed these were missing when I ran the profiler on a system with IPv6
Codecov Report
Patch coverage: 87.50% and project coverage change: -0.04 ⚠️
Comparison is base (
ac5c50a) 99.81% compared to head (0efa08d) 99.77%.
Additional details and impacted files
@@ Coverage Diff @@ ## master #1189 +/- ## ========================================== - Coverage 99.81% 99.77% -0.04% ========================================== Files 22 22 Lines 2719 2719 Branches 474 474 ========================================== - Hits 2714 2713 -1 Misses 3 3 - Partials 2 3 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/zeroconf/_core.py | 99.77% <87.50%> (-0.23%) |
⬇️ |
☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.
bdraco
marked this pull request as ready for review
bdraco
deleted the
reorder_incoming_data
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
1 participant