feat: add support for sending to a specific `addr` and `port` with `ServiceInfo.async_request` and `ServiceInfo.request` by bdraco · Pull Request #1192 · python-zeroconf/python-zeroconf

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@bdraco

Copy link Copy Markdown

Member

@bdraco bdraco commented

Jul 2, 2023

edited

Loading

Passing addr and port is optional, and will default to the mDNS multicast address and port. This is useful for directing requests to a specific host that may be able to respond across subnets.

…o.async_request

Passing addr and port is optional, and will default to the
mDNS multicast address and port. This is useful for directing
requests to a specific host that may be able to respond across
subnets.

@bdraco bdraco force-pushed the sending_to_addr branch from 549bf24 to 8f5efad Compare

July 2, 2023 14:27

@codecov

Copy link Copy Markdown

codecov bot commented

Jul 2, 2023

edited

Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8ae8ba1) 99.77% compared to head (8f5efad) 99.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1192   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          22       22           
  Lines        2721     2721           
  Branches      474      474           
=======================================
  Hits         2715     2715           
  Misses          3        3           
  Partials        3        3           
Impacted Files Coverage Δ
src/zeroconf/__init__.py 100.00% <100.00%> (ø)
src/zeroconf/_services/info.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco changed the title feat: Add support for sending to a specific addr/port with ServiceInfo.async_request feat: add support for sending to a specific addr and port with ServiceInfo.async_request and ServiceInfo.request

Jul 2, 2023

@bdraco bdraco marked this pull request as ready for review

July 2, 2023 14:32

@bdraco bdraco merged commit 405f547 into master

Jul 2, 2023

@bdraco bdraco deleted the sending_to_addr branch

July 2, 2023 14:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bdraco