feat: add support for sending to a specific `addr` and `port` with `ServiceInfo.async_request` and `ServiceInfo.request` by bdraco · Pull Request #1192 · python-zeroconf/python-zeroconf
Navigation Menu
{{ message }}
python-zeroconf / python-zeroconf Public
- Notifications You must be signed in to change notification settings
- Fork 229
Merged
Conversation
Copy link Copy Markdown
Member
Passing addr and port is optional, and will default to the mDNS multicast address and port. This is useful for directing requests to a specific host that may be able to respond across subnets.
bdraco
mentioned this pull request
…o.async_request Passing addr and port is optional, and will default to the mDNS multicast address and port. This is useful for directing requests to a specific host that may be able to respond across subnets.
bdraco
force-pushed
the
sending_to_addr
branch
from
549bf24 to
8f5efad
Compare
Copy link Copy Markdown
Codecov Report
Patch coverage: 100.00% and no project coverage change.
Comparison is base (
8ae8ba1) 99.77% compared to head (8f5efad) 99.77%.
Additional details and impacted files
@@ Coverage Diff @@ ## master #1192 +/- ## ======================================= Coverage 99.77% 99.77% ======================================= Files 22 22 Lines 2721 2721 Branches 474 474 ======================================= Hits 2715 2715 Misses 3 3 Partials 3 3
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/zeroconf/__init__.py | 100.00% <100.00%> (ø) |
|
| src/zeroconf/_services/info.py | 100.00% <100.00%> (ø) |
☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.
bdraco
changed the title
feat: Add support for sending to a specific addr/port with ServiceInfo.async_request
feat: add support for sending to a specific addr and port with ServiceInfo.async_request and ServiceInfo.request
bdraco
marked this pull request as ready for review
bdraco
merged commit
405f547
into
master
bdraco
deleted the
sending_to_addr
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment