fix: add missing if TYPE_CHECKING guard to generate_service_query by bdraco · Pull Request #1198 · python-zeroconf/python-zeroconf
Conversation
Copy link Copy Markdown
Member
This is a small cleanup but the primary goal here it to do a rebuild with cython 3
Copy link Copy Markdown
Codecov Report
Patch coverage: 100.00% and no project coverage change.
Comparison is base (
a56c776) 99.78% compared to head (71ddd13) 99.78%.
Additional details and impacted files
@@ Coverage Diff @@ ## master #1198 +/- ## ======================================= Coverage 99.78% 99.78% ======================================= Files 22 22 Lines 2728 2729 +1 Branches 474 473 -1 ======================================= + Hits 2722 2723 +1 Misses 3 3 Partials 3 3
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/zeroconf/__init__.py | 100.00% <100.00%> (ø) |
|
| src/zeroconf/_services/browser.py | 99.14% <100.00%> (+<0.01%) |
⬆️ |
☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.
bdraco
marked this pull request as ready for review
bdraco
merged commit
ac53adf
into
master
bdraco
deleted the
cast2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment