feat: add a cache to service_type_name by bdraco · Pull Request #1211

feat: add a cache to service_type_name by bdraco · Pull Request #1211 · python-zeroconf/python-zeroconf

Merged

bdraco merged 1 commit intomasterfrom

cache_service_type_name

Aug 3, 2023

Merged

feat: add a cache to service_type_name#1211
bdraco merged 1 commit intomasterfrom
cache_service_type_name

Conversation

Copy link Copy Markdown

Member

bdraco commented
Aug 3, 2023
•

edited

Loading

This function gets called all over the place and when we construct a lot of ServiceInfos for queries its the most expensive part. Since we tend to query the same records over and over when a ServiceBrowser is running, this can have quite a cost

feat: add a cache to service_type_name

5942902

This function gets call all over the place and when we construct
a lot of ServiceInfos for queries its the most expensive part. Since
we tend to query the same records over and over when a ServiceBrowser
is running, this can have quite a cost

bdraco mentioned this pull request

Aug 3, 2023

Fallback to sending unicast PTR queries when multicast is broken or packets are being dropped postlund/pyatv#2122

Merged

Copy link Copy Markdown

codecov bot commented
Aug 3, 2023
•

edited

Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3dba5ae) 99.78% compared to head (5942902) 99.78%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1211   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files          22       22           
  Lines        2749     2750    +1     
  Branches      477      478    +1     
=======================================
+ Hits         2743     2744    +1     
  Misses          3        3           
  Partials        3        3