Home Original page

feat: speed up unpacking text records in ServiceInfo by bdraco · Pull Request #1212 · python-zeroconf/python-zeroconf

Conversation

@bdraco

We now defer unpacking this until the property is accessed

The exception catch was a bit of a problem when processing a lot of records when looking at the profiling from postlund/pyatv#2122

@bdraco bdraco changed the title feat: speed up unpack text records in ServiceInfo feat: speed up unpacking text records in ServiceInfo

Aug 3, 2023

@codecov

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (32a016e) 99.78% compared to head (0394130) 99.78%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1212   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files          22       22           
  Lines        2750     2757    +7     
  Branches      478      480    +2     
=======================================
+ Hits         2744     2751    +7     
  Misses          3        3           
  Partials        3        3
Files Changed Coverage Δ
src/zeroconf/_services/info.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review

August 3, 2023 23:56

@bdraco bdraco deleted the set_text_cleanup branch

August 4, 2023 00:36

1 participant

@bdraco